Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battery modification #2625

Merged
merged 8 commits into from
Jul 6, 2023
Merged

Battery modification #2625

merged 8 commits into from
Jul 6, 2023

Conversation

nicolas-pierr
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?
Add a Battery modification to change targetQ for OpenReac project

Nicolas Pierre added 2 commits June 22, 2023 15:03
Signed-off-by: Nicolas Pierre <nicolas.pierre@artelys.com>
Signed-off-by: Nicolas Pierre <nicolas.pierre@artelys.com>
@nicolas-pierr nicolas-pierr self-assigned this Jun 22, 2023
Signed-off-by: Nicolas Pierre <nicolas.pierre@artelys.com>
@nicolas-pierr nicolas-pierr changed the title Bbattery modification Battery modification Jun 26, 2023
@annetill annetill requested review from olperr1 and annetill June 26, 2023 13:55
annetill and others added 4 commits July 6, 2023 08:12
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
Copy link
Member

@olperr1 olperr1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The following line is missing from the license header of the newly created files:

SPDX-License-Identifier: MPL-2.0

Signed-off-by: Anne Tilloy <anne.tilloy@rte-france.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.7% 81.7% Coverage
0.0% 0.0% Duplication

@olperr1 olperr1 merged commit bd5e6d4 into main Jul 6, 2023
@olperr1 olperr1 deleted the iidm-modification/battery-modif branch July 6, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants